Initial Function as Argument support for code2amr #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Free-Quarks
changed the title
github-actions bot
added a commit
that referenced
this pull request
Dec 7, 2023
## Summary of Changes This updates the database.rs to support function calls as arguments, this required adding support for sub-expressions inside expressions. These sub-expressions are related to the calling of the argument functions This also updates model_extraction.rs to add support for handling these sub-expressions to get the full AMR's out. This includes new trimming to delete the sub-expressions while connecting the primitives directly to the argument functions. ### Related issues Resolves #622 --------- Co-authored-by: Justin <[email protected]> 094b7ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This updates the database.rs to support function calls as arguments, this required adding support for sub-expressions inside expressions. These sub-expressions are related to the calling of the argument functions
This also updates model_extraction.rs to add support for handling these sub-expressions to get the full AMR's out. This includes new trimming to delete the sub-expressions while connecting the primitives directly to the argument functions.
Related issues
Resolves #622